Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AbstractCraftingRecipeBuilder #155

Merged
merged 5 commits into from
Apr 6, 2024
Merged

Create AbstractCraftingRecipeBuilder #155

merged 5 commits into from
Apr 6, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • change Astral Sorcery Starlight Altar to always require 1 starlight, and update example to have 500 starlight
  • improve description of @Property javadoc, and restrict its use so it always works (can no longer have @Properties on FIELD/METHOD, since those are either singleton or need to use @RecipeBuilderDescription#requirements)
  • fixed Astral Sorcery Starlight Altar documentation generation not quite working correctly, and simplified internal code.
  • adds AbstractCraftingRecipeBuilder and removes a huge amount of duplicate code relating to that.

brachy84
brachy84 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@brachy84 brachy84 merged commit 4a30a55 into CleanroomMC:master Apr 6, 2024
@brachy84 brachy84 added the refactor Something is rewritten label Apr 6, 2024
@WaitingIdly WaitingIdly deleted the crafting-recipe-builders branch April 7, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
refactor Something is rewritten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84