-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameObjectHandler enhancement #156
Conversation
src/main/java/com/cleanroommc/groovyscript/compat/mods/ModPropertyContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/ModPropertyContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/ModSupport.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/draconicevolution/DraconicEvolution.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/vanilla/VanillaContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/gameobjects/GohMetaMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandlerManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the comments are about error logging or similar situations still referring to Object Mappers
as Game Object Handlers
or even Bracket Handlers
. this effect also happens in comments/javadocs, but as thats much more internal developer stuff and was largely not part of the diff, was not specifically commented on. these situations should get their terminology modernized.
src/main/java/com/cleanroommc/groovyscript/compat/mods/mekanism/Mekanism.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/gameobjects/GohMetaMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMapperManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMapperManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMappers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMappers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/sandbox/transformer/GroovyScriptTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/api/IGroovyContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/api/IGameObjectParser.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/com/cleanroommc/groovyscript/compat/mods/tinkersconstruct/Casting.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/tinkersconstruct/TinkersConstruct.java
…' into goh-enhancement # Conflicts: # src/main/java/com/cleanroommc/groovyscript/compat/mods/ModPropertyContainer.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/alchemistry/Alchemistry.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/botania/Botania.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/draconicevolution/DraconicEvolution.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/evilcraft/EvilCraft.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/roots/Roots.java # src/main/java/com/cleanroommc/groovyscript/compat/mods/thermalexpansion/ThermalExpansion.java # src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandlerManager.java
mods.modid.goh_name
for all gohs added by modsIDynamicGroovyProperty
. It still works, but its not used here and lsp support was removed. Instead propertties should be added viaExpansionHelper.mixinProperty()
initialize(GroovyContainer)
method toModPropertyContainer
and deprecate the old oneIRegistrar
and move its methods toGroovyContainer
addPropertyFieldsOf()
in mod compatHidden
interface for meta methods and properties. This allows methods and properties to hide from suggestions via lsp. Useful to hide alias variationsGroovyConatiner#gameObjectHandlerBuilder()
, this makes sure its registered correctly for the mod