Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make MethodDescription#description check for a global fallback #158

Merged
merged 3 commits into from
Apr 15, 2024
Merged

make MethodDescription#description check for a global fallback #158

merged 3 commits into from
Apr 15, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • made @MethodDescription#description check for global fallback key if exact key isnt defined
    • old flow: key -> use desc if not empty -> use the exact key
    • new flow: key -> use desc if not empty -> check exact key, use if exists -> check global key, use if exists -> use exact key (missing keys should log exact key)
  • apparently the mixer was using the removeByOutput key for a removeByInput method, so that got fixed

@brachy84 brachy84 merged commit 6879bf5 into CleanroomMC:master Apr 15, 2024
@WaitingIdly WaitingIdly deleted the documentation-fallback branch April 16, 2024 15:23
@WaitingIdly WaitingIdly added the documentation Improvements or additions to documentation label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84