Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ProjectE compat #163

Merged
merged 3 commits into from
Jul 3, 2024
Merged

add ProjectE compat #163

merged 3 commits into from
Jul 3, 2024

Conversation

WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented May 4, 2024 •
edited
Loading

changes in this PR:

  • adds EntityRandomizer (for both peaceful and mob lists) and Transmutation compat.
  • adds examples file and i18n wiki keys for the above compat.

brachy84
brachy84 reviewed Jun 16, 2024
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to split mob and peaceful entity randomaizer?

@WaitingIdly
Copy link
Collaborator Author

no, but i dont see the harm in having them split

@brachy84
Copy link
Member

I do: confusion, inconvenient and unintuitive

@WaitingIdly
Copy link
Collaborator Author

merged the two categories

@brachy84 brachy84 merged commit 7a7eb44 into CleanroomMC:master Jul 3, 2024
@WaitingIdly WaitingIdly deleted the projecte branch July 3, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
mod compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84