generated from CleanroomMC/TemplateDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Cleanup of IDE warnings, also small bugfixes #179
Merged
brachy84
merged 32 commits into
CleanroomMC:master
from
WaitingIdly:fix-simple-warnings-and-remove-some-pair
Jun 16, 2024
Merged
Minor Cleanup of IDE warnings, also small bugfixes #179
brachy84
merged 32 commits into
CleanroomMC:master
from
WaitingIdly:fix-simple-warnings-and-remove-some-pair
Jun 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
force-pushed
the
fix-simple-warnings-and-remove-some-pair
branch
from
June 16, 2024 07:59
d494d9b
to
6b4d0d1
Compare
brachy84
reviewed
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of removing initalisation of fields even if its their default value. It helps make the code more readable and less ambiguous. Also the 1f
-> 1.0f
seems unecessary, but its fine.
src/main/java/com/cleanroommc/groovyscript/compat/mods/mekanism/ChemicalOxidizer.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
null
or0
, when that is already the default)@Override
annotations where they ought to bename
usesuper.name
in recipe builders where it can be confused for thename
in the parent classregister
correctlyPair<ResourceLocation, Recipe>
(Recipe has the RL, its pointless)@MethodDescription(description = "x")
wherex
could be assumedgradle.properties
to allow thatgradle.properties
debug stuff and comment itmode
being renamed tocompactorMode
not having documentation or examples updatedremoves ~480 warnings, which according to my IDE, means only 460 left in the groovyscript folder.