Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Cleanup of IDE warnings, also small bugfixes #179

Merged

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • engage in a significant amount of "IDE warning gets autofixed" action
    • weaken overly strong variables
    • less modification of method parameters
    • one line per variable/field declaration
    • remove redundant field creation (eg null or 0, when that is already the default)
    • apply @Override annotations where they ought to be
    • make name use super.name in recipe builders where it can be confused for the name in the parent class
    • remove unused imports
    • use pattern variable
    • use improved switch format
    • make finalizable fields final
    • a few more minor things
  • make Blood Magic return the recipe in register correctly
  • store only the recipe in most roots stuff, instead of Pair<ResourceLocation, Recipe> (Recipe has the RL, its pointless)
  • fix some extended crafting shapeless recipes actually being shaped recipes
  • remove some instances of @MethodDescription(description = "x") where x could be assumed
  • add the ability for java arguments to control documentation, and add settings to gradle.properties to allow that
  • reorder the gradle.properties debug stuff and comment it
  • fix mode being renamed to compactorMode not having documentation or examples updated

removes ~480 warnings, which according to my IDE, means only 460 left in the groovyscript folder.

@WaitingIdly WaitingIdly force-pushed the fix-simple-warnings-and-remove-some-pair branch from d494d9b to 6b4d0d1 Compare June 16, 2024 07:59
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of removing initalisation of fields even if its their default value. It helps make the code more readable and less ambiguous. Also the 1f -> 1.0f seems unecessary, but its fine.

@brachy84 brachy84 merged commit c4b572f into CleanroomMC:master Jun 16, 2024
@WaitingIdly WaitingIdly deleted the fix-simple-warnings-and-remove-some-pair branch June 17, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants