Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Aurorian compatibility #183

Merged
merged 8 commits into from
Jul 22, 2024

Conversation

Wizzerinus
Copy link
Contributor

The processing machines in the mod are very simple, so should be pretty straightforward

Added machines: Scrapper, MoonlightForge

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Jun 22, 2024
@Wizzerinus
Copy link
Contributor Author

probably fixed these comments

@Wizzerinus
Copy link
Contributor Author

fixed the former, don't think latter is necessary personally? can still implement that if needed, but just like, why

@MethodDescription(example = @Example("item('theaurorian:aurorianiteingot')"))
public boolean removeByInput(IIngredient output) {
@MethodDescription(example = @Example("item('theaurorian:moonstonesword'), item('theaurorian:aurorianiteingot')"))
public boolean removeByInput(IIngredient input, IIngredient catalyst) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should give this a specific lang key, currently it will be using the general groovyscript.wiki.removeByInput. theres technically a groovyscript.wiki.removeByInputAndCatalyst thats used, but its used all of one place, so i would suggest using a custom lang key description here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@WaitingIdly WaitingIdly Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, how viable would doing this be?

    @MethodDescription(example = @Example("item('theaurorian:moonstonesword')")
    public boolean removeByInput(IIngredient input) {
        return MoonlightForgeRecipeHandler.allRecipes.removeIf(r -> {
            if (input.test(r.getInput1()) || input.test(r.getInput2())) {
                addBackup(r);
                return true;
            }
            return false;
        });
    }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats how it was before? I think if it has to inputs you should supply 2 inputs to match for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's literally what it was before my changes in the last 2 days. I can roll back if needed.

@Wizzerinus Wizzerinus closed this Jul 7, 2024
@Wizzerinus Wizzerinus deleted the compat/aurorian branch July 7, 2024 12:35
@Wizzerinus Wizzerinus restored the compat/aurorian branch July 7, 2024 12:36
@Wizzerinus
Copy link
Contributor Author

Accident

@Wizzerinus Wizzerinus reopened this Jul 7, 2024
@brachy84 brachy84 merged commit 81fd37e into CleanroomMC:master Jul 22, 2024
@Wizzerinus Wizzerinus deleted the compat/aurorian branch July 23, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants