-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add The Aurorian compatibility #183
Conversation
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/MoonlightForge.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/Scrapper.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/TheAurorian.java
Outdated
Show resolved
Hide resolved
probably fixed these comments |
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/MoonlightForge.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/MoonlightForge.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/theaurorian/MoonlightForge.java
Show resolved
Hide resolved
fixed the former, don't think latter is necessary personally? can still implement that if needed, but just like, why |
@MethodDescription(example = @Example("item('theaurorian:aurorianiteingot')")) | ||
public boolean removeByInput(IIngredient output) { | ||
@MethodDescription(example = @Example("item('theaurorian:moonstonesword'), item('theaurorian:aurorianiteingot')")) | ||
public boolean removeByInput(IIngredient input, IIngredient catalyst) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should give this a specific lang key, currently it will be using the general groovyscript.wiki.removeByInput
. theres technically a groovyscript.wiki.removeByInputAndCatalyst
thats used, but its used all of one place, so i would suggest using a custom lang key description here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, how viable would doing this be?
@MethodDescription(example = @Example("item('theaurorian:moonstonesword')")
public boolean removeByInput(IIngredient input) {
return MoonlightForgeRecipeHandler.allRecipes.removeIf(r -> {
if (input.test(r.getInput1()) || input.test(r.getInput2())) {
addBackup(r);
return true;
}
return false;
});
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats how it was before? I think if it has to inputs you should supply 2 inputs to match for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's literally what it was before my changes in the last 2 days. I can roll back if needed.
# Conflicts: # dependencies.gradle
Accident |
The processing machines in the mod are very simple, so should be pretty straightforward
Added machines:
Scrapper
,MoonlightForge