generated from CleanroomMC/TemplateDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hand command functionality #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
added
enhancement
New feature or request
refactor
Something is rewritten
labels
Jul 22, 2024
brachy84
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally not a fan of adding many classes with only ~5 lines of difference
brachy84
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nice, but
- the
'modid:name', meta
->'modid:name:meta'
needs to be changed back. I absolutly hate that. You could add aW = Short.MAX_VALUE
global variable. - As is said having 20+ classe with only ~5 lines of difference is a waste i think. Builders would be much more beatiful (debatable).
- I don't really like the colors of the printed info (the bold pink headers for example). I know this was not done in this pr.
Also where entity nbt |
Error when i do /grs self
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
IngredientHelper.asGroovyCode
methods intoGroovyScriptCodeConverter.asGroovyCode
, and add functionality:Short.MAX_VALUE
, display the ItemStack metadata asmod:item:*'
instead of displaying it asmod:item', 32767
.biome
,profession
,career
,dimension
,entity
,creativeTab
,enchantment
,potion
, andblock
.PotionEffect
./gs hand
command into four commands:/gs hand
remains, but only uses an item in the main hand or offhand./gs looking
ignores any item in a hand, and gets the block or entity being looked at, preferring to target an entity, if any exist./gs self
uses the player and attaches no other information./gs info
checks items in hand, then entity being looked at, then block being looked at, and then uses the self.GsHandEvent
, and add entity and blockpos fields to it.biome
,block
,blockstate
,creativetab
,dimension
,enchantment
,entity
,fluid
,item
,oredict
,potioneffect
,nbt
,translation
,villagercareer
, andvillagerprofession
.aspect
,brew
,compound
,constellation
,element
,gas
,herb
,infusion
,jeitab
,modifier
,spell
,tunnel
, andweather
./gs hand item block
or/gs info -entity -dimension
pretty
setting.tldr: standardize hand command and make it more usable