Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recipes using a RecipeBuilder in more situations #202

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add more ability to add Aspects to Thaumcraft Infusion and Crucible Recipe Builders.
  • make the Thaumcraft Crucible Recipe Builder create the CrucibleRecipe in the register method, instead of calling a different method.
  • add a lens field and validation to Actually Additions Atomic Reconstructor.
  • convert (most) cases of adding recipes via shorthand to refer to the relevant Recipe Builder. the benefits of this include:
    • improved error logging due to using the more robust validation methods in every situation
    • reduced code duplication
    • revealing several errors with some of the current add methods
  • fixes several add methods using Minecraft's Ingredient instead of GroovyScript's IIngredient or otherwise using types that are harder for GroovyScript to obtain.

@brachy84 brachy84 added enhancement New feature or request mod compat Relating to compatability with a mod or features of a mod labels Jul 22, 2024
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@brachy84 brachy84 merged commit 8911f99 into CleanroomMC:master Jul 24, 2024
@WaitingIdly WaitingIdly deleted the add-via-builder branch July 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants