Resolve Symbolic Links in Groovy Folder in Debug Mode #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntegerLimit
changed the title
|
Change: Only followed in Debug Mode. |
brachy84
approved these changes
Aug 14, 2024
brachy84
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly resolves Symbolic Links when searching through the
groovyfolder to find scripts. This means that sub folders and individual files of thegroovyfolder can now be symlinked (postInitfolder or folders insidepostInit, etc.), rather than having the wholegroovyfolder required to be symlinked beforehand.This results in potential improvements for developers.
This might introduce cases where recursive symlinks cause an infinite walk, which could be controlled with a limit on directory search, but given the rarity of such a case, and potential issues directory search limits could introduce, this has not been directly added in this PR.