Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Recipes from JEI #212

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Aug 1, 2024

changes in this PR:

  • add a general keybind folder.
  • extract the Groovy reload keybind to that folder.
  • add a remove recipe key (default: CTRL+X).
  • add a few new methods to the GroovyScriptCodeConverter
    • format resource location.
    • format itemstack or fluidstack without quantity.
  • add some new minor accessors for JEI.
  • add a mechanism to obtain a number of removal methods for the focused category in JEI.
    • 255 total implementations
    • documented

not currently finished. things not yet solved:

  • generation of some removal methods generates methods that dont exist/are otherwise incorrect.
    • went through most of the categories, most should work properly.
      requires going through every category and checking, and either doing .input("newName").output("newName") or creating new methods.
    • disabled line, should be reenabled in a later PR when the method is added.
      creation of the removeByExactInput method or commenting out the relevant line (currently line 54 of OperationHandler).
  • should have a better way to iterate through all registries.
  • add comments // todo jei to indicate that new methods need to be created for the given compat.
    current count: 15.

primary files to review: IJEIRemoval, JeiRemovalHelper, OperationHandler, and RemoveRecipeKey.
for more advanced implementations of the Operation logic, see IJEIRemovalGas, Crafting, ArcFurnace, and StarlightAltar.

@WaitingIdly WaitingIdly added the enhancement New feature or request label Aug 1, 2024
@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Aug 1, 2024
@WaitingIdly WaitingIdly marked this pull request as ready for review August 2, 2024 09:01
@WaitingIdly WaitingIdly marked this pull request as draft August 3, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant