Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Botania Support #54

Merged
merged 7 commits into from
May 16, 2023
Merged

Botania Support #54

merged 7 commits into from
May 16, 2023

Conversation

Testure
Copy link
Contributor

@Testure Testure commented May 15, 2023

Adds support for Botania.

Adds recipes additon/removal for:

  • The Brewing Stand
  • The Petal Apothecary
  • The Rune Altar
  • Elven Trade
  • Mana Infusion
  • The Pure Daisy
  • The Orechid
  • The OrechidIgnem

Adds support for adding/removing blocks and items from the magnet blacklist.
Adds convenience methods for registering custom flowers.
Adds support for adding custom brews.
Adds support for adding custom knowledge types.
Adds support for adding/removing lexicon categories.
Adds support for adding/removing lexicon entries.
Adds support for adding/removing lexicon pages.

Copy link
Member

@Rongmario Rongmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things and an example script file and it'll be ready.

Comment on lines 22 to 26
if (subClass.getSimpleName().equals("Mini") && SubTileEntity.class.isAssignableFrom(subClass)) {
BotaniaAPI.registerMiniSubTile(name + "Chibi", (Class<? extends SubTileEntity>) subClass, name);
BotaniaAPI.registerSubTileSignature((Class<? extends SubTileEntity>) subClass, new BasicSignature(name + "Chibi"));
BotaniaAPI.addSubTileToCreativeMenu(name);
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was some scuffed requirement in Botania's internal registration, perhaps make this more clearer and explicit?

@Rongmario Rongmario merged commit e106dce into CleanroomMC:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants