Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvilCraft compat #58

Merged
merged 8 commits into from
Jun 25, 2023
Merged

EvilCraft compat #58

merged 8 commits into from
Jun 25, 2023

Conversation

WaitingIdly
Copy link
Collaborator

what this PR adds:

  • bracket handler to get EvilCraft weather types
  • compat with both EvilCraft Blood Infuser and Environmental Accumulator.
  • an examples file for the above
  • fixes a typo in AbstractRecipeBuilder's error logging.

brachy84
brachy84 requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a one liner for bloodinfuser as the builder is rather short

src/main/java/com/cleanroommc/groovyscript/compat/mods/evilcraft/BloodInfuser.java Show resolved Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/evilcraft/BloodInfuser.java Outdated Show resolved Hide resolved
@brachy84 brachy84 merged commit 339ddfa into CleanroomMC:master Jun 25, 2023
@WaitingIdly WaitingIdly deleted the evilcraft branch June 25, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
mod compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84