Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chisel compat #61

Merged
merged 6 commits into from
Jun 25, 2023
Merged

Chisel compat #61

merged 6 commits into from
Jun 25, 2023

Conversation

WaitingIdly
Copy link
Collaborator

what this PR adds:

  • add sound bracket handler
  • fix typo in extendedcraft.groovy example file (was called extremecrafting)
  • add chisel compat for creating or removing groups and adding or removing items from groups
  • add error handling for oredict groups (cannot remove items from the chisel variation, have to remove the items from the oredict)
  • an examples file for the above

Copy link
Contributor

@Testure Testure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You turned my scroll bar yellow with NPE warnings. Other than that, looks good.

@brachy84 brachy84 merged commit dd05b8c into CleanroomMC:master Jun 25, 2023
@WaitingIdly WaitingIdly deleted the chisel branch June 25, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants