Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a varargs variant for yeeting items in JEI #70

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Add a varargs variant for yeeting items in JEI #70

merged 4 commits into from
Aug 1, 2023

Conversation

Testure
Copy link
Contributor

@Testure Testure commented Jun 29, 2023

Allows you to yeet a ton of items at the same time via varargs, which is both more convenient and more performant.

WaitingIdly
WaitingIdly requested changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@WaitingIdly WaitingIdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds varargs for removeAndHide/yeet, but is missing varargs for hide. Additionally, in places where we use varargs removal we typically have a Collection<T> version, to allow either remove(x,y,z) or remove([x, y, z]).

src/main/java/com/cleanroommc/groovyscript/compat/mods/jei/JustEnoughItems.java Outdated Show resolved Hide resolved
@brachy84 brachy84 merged commit a8819ae into CleanroomMC:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaitingIdly WaitingIdly WaitingIdly requested changes

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Testure @WaitingIdly @brachy84