add AE2 compat #71
Merged
add AE2 compat #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
reviewed
Aug 1, 2023
examples/appliedenergistics2.groovy
Outdated
| // Bracket Handlers | ||
|
|
||
| // Get the P2P Tunnel type from the enum. Case insensitive. | ||
| tunnel('me') |
There was a problem hiding this comment.
I wonder if it would be better to add something like this to the mod compat class so it would look like 'mods.ae2.tunnel('me')'
There was a problem hiding this comment.
at the very least having that as an alternate way to get bracket handlers would be a good idea.
brachy84
requested changes
Aug 1, 2023
src/main/java/com/cleanroommc/groovyscript/compat/mods/appliedenergistics2/Grinder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/appliedenergistics2/Inscriber.java
Outdated
Show resolved
Hide resolved
WaitingIdly
added
the
mod compat
brachy84
approved these changes
Aug 3, 2023
# Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what this PR adds: