generated from CleanroomMC/TemplateDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra examples, a small PR with minor changes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 3, 2023
brachy84
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine and definitly read everything
src/main/java/com/cleanroommc/groovyscript/compat/EnergyRecipeBuilder.java
Show resolved
Hide resolved
brachy84
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as "What if I added examples to the mods which have compat but no examples", easily moved into "Well I should also touch up the existing examples", and turned into "wow our compat has some bugs. should fix those. oh yeah and also should add...".
oops.
What this PR adds:
runConfig.json
example to reflect current capabilities (removed packmodes & asm, added packId and debug)AlchemyArray#removeByOutput(ItemStack)
check viaisItemEqual
rather thanareItemStacksEqual
.%s
into{}
because objects were being logged, not strings, and {} is generally preferred.build.gradle
must be in the order of experimental > classic.codechicken_lib
be loaded if either thermal or draconic evolution is being debugged.onReload
functions inverted (was trying to remove backups and adding duplicate scripted).Apothecary#removeByInput(IIngredient...)
not checking both required variables to determine if they are strings.Lightwell.RecipeBuilder#validate()
always returning false, and thus any Lightwell recipes not being added.RecipeBuilder
to EnderIO'sTankMachineRecipe
.streamRecipes()
andremoveAll()
methods to any EnderIO compat that was missing them.streamRecipes()
andremoveAll()
methods to any Astral Sorcery compat that was missing them.RecipeBuilder
andremoveAll()
method to all Mekanism recipes.RecipeBuilder
andremoveAll()
method to the Vanilla Furnace.removeAll()
method to Draconic Evolution's Fusion.removeAll()
method to Vanilla OreDict.removeAll()
method to Vanilla Crafting.ManaInfusion#removeByCatalyst(IBlockState)
to remove all recipes with a given catalyst for Botania's Mana Infusion.Squeezer#removeByOutput(ItemStack)
to remove an Immersive Engineering Squeezer recipe that has no fluid output.char: IIngredient
s into all Shaped crafting recipes (Arcane, Ender, Table, Astral, Crafting).PetalApothecary
as an alias to Botania's Apothecary.GasRecipeBuilder
forgasInput
andgasOutput
use.GroovyHelper.getPackId()
, a shorthand way to get the pack ID that is automatically imported into every Groovy file.ItemStack#setRarity(TextFormatting)
.EnergyRecipeBuilder
andTimeRecipeBuilder
(adding anint time
andint energy
to the builder, respectively) and moved the 4 lines of code into relevant classes.xpChance
method toxp
(its an 100% chance and controls the amount of xp).DRACONIC_EVO
toDRACONIC_EVOLUTION
. should be an entirely internal change.replace()
andreplaceByName()
in Crafting.GroovyPerkTree
toPerkTree
.