move from Embers-Rekindled to Embers Unofficial Extended Life #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used ForgeRegistry in combination with a resource location to lookup the required blocks. That way both versions Embers Rekindled and Embers Unofficial Extended Life work with Multiblocked. Tested them both locally. |
Rongmario
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in November 2023 I decided to fork Embers Rekindled as there was no sign that it will be maintained for 1.12 any time soon. After some refactoring I want to restore compatibility with multiblocked. This pull request simply reflects the registry changes.
This makes the mod incompatible with Embers-Rekindled not that it should be used anymore, but I wanted to mention it.