Sounds: fix persistent weather effects

[dseguin]

Summary

None

Purpose of change

• Fix Outside sounds don't stop when you get inside #58995

Weather sound effects (WEATHER_*) do not fade out like other environment variants like daytime, so the audio channel will continue to play until a different weather SFX is encountered.

Describe the solution

Fade out outdoor* channels when player is deaf or indoors, or if weather is silent.

Describe alternatives you've considered

I thought initially that there might be an issue with find_random_effect(), but it seems to be selecting the appropriate effects.

Testing

Following the steps in the linked issue:

• Using CC-Sounds
• Walk indoors from outside
• WEATHER_CLEAR effect fades out

Tested in-game audio:

2022-07-11.21-30-53.mp4

Additional context