Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIM: keep ui_adaptor running during move activities #62400

Merged
merged 1 commit into from
Nov 29, 2022
Merged

AIM: keep ui_adaptor running during move activities #62400

merged 1 commit into from
Nov 29, 2022

Conversation

andrei8l
Copy link
Contributor

@andrei8l andrei8l commented Nov 26, 2022 •
edited
Loading

Summary

None

Purpose of change

Keep the AIM open when moving items to prevent bright flashes
Fixes: #57585

Describe the solution

Keep the ui_adaptor running while moving items

Describe alternatives you've considered

Zen

Testing

  1. Open the AIM and move one/all items. Try again with the source pane set to All, which has a completely separate processing path for reasons. Try again with the destination pane set to Inventory, which has a completely separate processing path for reasons.
  2. Spawn a zombie or otherwise set up an interruption (including cancelling manually) and try 1 again
  3. Close and reopen the AIM after 1 and 2. Everything should work as expected

Additional context

I-am-Erk ping back

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 26, 2022
@mqrause
Copy link
Contributor

mqrause commented Nov 26, 2022

Does this still allow manual interruption?

@andrei8l

This comment was marked as off-topic.

Sign in to view
@andrei8l andrei8l force-pushed the aim-keep branch 2 times, most recently from 1f8271c to c7895b2 Compare November 26, 2022 12:20
@NetSysFire NetSysFire added the Accessibility Issues regarding accessibility label Nov 26, 2022
@andrei8l andrei8l marked this pull request as ready for review November 27, 2022 04:10
@andrei8l andrei8l marked this pull request as draft November 27, 2022 19:00
@andrei8l andrei8l marked this pull request as ready for review November 27, 2022 19:19
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 27, 2022
@andrei8l andrei8l force-pushed the aim-keep branch 2 times, most recently from 1f55d1c to c46fe47 Compare November 27, 2022 20:53
@andrei8l andrei8l marked this pull request as draft November 27, 2022 21:04
@andrei8l andrei8l marked this pull request as ready for review November 27, 2022 21:19
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 28, 2022
@I-am-Erk I-am-Erk merged commit 210208a into CleverRaven:master Nov 29, 2022
@andrei8l andrei8l deleted the aim-keep branch November 29, 2022 19:23
andrei8l added a commit to andrei8l/Cataclysm-DDA that referenced this pull request Nov 30, 2022
@andrei8l
AIM: hotfix for CleverRaven#62400
f4a5371
@andrei8l andrei8l mentioned this pull request Nov 30, 2022
Merged
andrei8l added a commit to andrei8l/Cataclysm-DDA that referenced this pull request Nov 30, 2022
@andrei8l
AIM: hotfix for CleverRaven#62400
24e528f
I-am-Erk pushed a commit that referenced this pull request Nov 30, 2022
@andrei8l
AIM: hotfix for #62400 (#62489)
a029cf8
@andrei8l andrei8l mentioned this pull request Dec 3, 2022
Merged
@Kamayana Kamayana mentioned this pull request Dec 4, 2022
Closed
@Kamayana Kamayana mentioned this pull request Jan 31, 2023
Closed
@andrei8l andrei8l mentioned this pull request Dec 4, 2023
Closed
@alef alef mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accessibility Issues regarding accessibility astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid possible epilepsy hazard by keeping Adv Inventory open during brief tasks
4 participants
@andrei8l @mqrause @I-am-Erk @NetSysFire