Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another density cleanups, and more #70370

Merged
merged 10 commits into from
Dec 24, 2023
Merged

Another density cleanups, and more #70370

merged 10 commits into from
Dec 24, 2023

Conversation

GuardianDll
Copy link
Member

Summary

None

Describe the solution

Fix various densities
Added some materials to cover items that has lack of material
Remove gravelbag, sandbag and soilbag in favor of actual bug with this stuff, tweaked recipes respecitvely, added bag_durasack to store them
Tweaked some values for spearguns
Add wrapper foil roll that store wrappers same as tape roll
and maybe more

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Archery Bows, crossbows, arrows, bolts Items: Containers Things that hold other things Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions labels Dec 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A large and sturdy sack, made out of some plastic material; Popular choise to store sand, gravel, cement, or stop some local flood.
  • Long tube of cardboard, used to conveniently store long steets of foil.
  • double roller spearguns
  • long spearguns
  • workbenches (folded)

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 23, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 23, 2023
@Maleclypse Maleclypse merged commit 8051970 into CleverRaven:master Dec 24, 2023
19 of 23 checks passed
@GuardianDll GuardianDll deleted the bad_density branch December 24, 2023 00:59
@GuardianDll GuardianDll mentioned this pull request Dec 25, 2023
Merged
gkarfakis19 pushed a commit to gkarfakis19/Cataclysm-DDA that referenced this pull request Jan 3, 2024
@GuardianDll @gkarfakis19
Another density cleanups, and more (CleverRaven#70370)
299f02f 
* some stuff

* a bit more

* fix spearguns

* fixing bolts, obsoleting explosive arrows and bolts

* fix few another stuff, fix wrapper foil

* mooore fixes

* Kill gravelbag, sandbag and soilbags

* fixing my mistakes

* more fixes

* and more
@RenechCDDA RenechCDDA mentioned this pull request Jan 31, 2024
Open
@VladMasarik VladMasarik mentioned this pull request Mar 24, 2024
Merged
@Miner239 Miner239 mentioned this pull request Jul 31, 2024
Merged
@EvanBalster
Copy link
Contributor

I noticed some issues with the new foil roll:

  1. The foil wrapper can't be used because it can't be removed from the roll or disassembled. Unlike duct tape it doesn't factor directly into any crafting recipes.
  2. Kitchen 'junk drawers' tend to generate dozens of almost-empty foil rolls instead of one roll containing many sheets.

See here: #76733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Archery Bows, crossbows, arrows, bolts Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuardianDll @EvanBalster @Maleclypse