Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oversize Reinforced Cardboard Box #73342

Merged

Conversation

TheMurderUnicorn
Copy link
Contributor

@TheMurderUnicorn TheMurderUnicorn commented Apr 27, 2024

Summary

Content "Add Oversize Reinforced Cardboard Box"

Purpose of change

#72510 pointed out/request that there be a reinforced version of the oversize cardboard box, since on existed for the large cardboard box.

Describe the solution

Added the item, the recipe, and added the recipe to the nested list for cardboard boxes. Reinforced is double the weight capacity, having been reinforced with a second box and lots of duct tape.

Describe alternatives you've considered

I'm not sure we actually need this, seems very niche but whatever it took like 10 minutes to put together.

Testing

Tested everything, spawned the box, made sure it wasn't foldable or deployable, tested the recipe appears correctly, tested to ensure it was in the right nested group.
image

Additional context

It can't be deployed (because oversize boxes can't be deployed), it's the only box that doesn't have ascii art (because I wasn't sure how to do that/didn't care), and I still find the item somewhat questionable but it is in line with the existing reinforced large box in the ways that matter, so it's consistent. closes #72510

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 27, 2024
Copy link
Contributor

@DragonWizard23 DragonWizard23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first review and I'm happy to receive feedback! I just have two suggestions: the pre-apoc price and the weight, where I've added in-line comments. Overall, your work looks good!

data/json/items/containers/containers.json Outdated Show resolved Hide resolved
data/json/items/containers/containers.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 27, 2024
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 27, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 30, 2024
@Maleclypse Maleclypse merged commit 9c601d0 into CleverRaven:master May 3, 2024
20 of 24 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the OversizeReinforcedCardboardBox branch May 3, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinforced oversize cardboard box
3 participants