Break recursive death spiral

[PatrikLundell]

Summary

None

Purpose of change

Break recursive death spiral revealed by #74287.

Describe the solution

Clear the cache dirty flag at the call rather than at the end so calls from rebuild_aim_cache won't call it down the line.

Describe alternatives you've considered

Understand why the code for setting the cache even involves checking for the cache being dirty in the first place.

Testing

Loaded save, spawned m16, wielded it, walked over to zombie miners, aimed. I was able to fire at a miner after aiming one step at a time to full aiming.

Additional context

Note that #74287 didn't cause the bug, just revealed the bug when another one was corrected (the bug can can probably be repeated with the pre #74287 correction code if you're at OMT (0, 0, 0) and the target is in the reality bubble at a position that leaves it with positive absolute coordinate members (x and y above zero)).

[osuphobia]

Understand why the code for setting the cache even involves checking for the cache being dirty in the first place.

Cataclysm-DDA/src/lightmap.cpp

Lines 692 to 696 in b8f906a

	// possibly reduce view if aiming (also blocks light)
	if( get_avatar().recoil < MAX_RECOIL ) {
	if( get_avatar().cant_see( p ) ) {
	return { true, true, 0.0 };
	}

Aiming will reduce your visual field, and seems that we are rebuilding aim cache while refreshing the lightmap (and only calling rebuild_aim_cache here).
(Edit:

Cataclysm-DDA/src/cata_tiles.cpp

Line 4107 in b8f906a

const bool scope_is_blocking = you.is_avatar() && you.as_avatar()->cant_see( p );

Also calling it here.)
Do you have any idea how we can improve this part?

[PatrikLundell]

No, I don't have any knowledge of the code. but there is something wrong with code that risks infinite recursion. The problem is that it's such a long call chain, so it's not merely a matter of factoring out a common part of some code to avoid the risk of recursion.