Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic bird egg, replace its role with chicken egg #76090

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Aug 31, 2024

Summary

None

Purpose of change

Our generic wild bird egg has actually been unused for anything but a glorified template for a while now. All values it had were based off chicken eggs anyway, so we can just cut out the middleman and use the chicken egg as the template (which, in vanilla, we already were doing)

Describe the solution

As the item was not actually present ingame anywhere save for the crafting UI, this gives no gameplay changes without mods

With mods, however, MoM players will now have a properly updated bird egg requirement group. The JSON comment was lying - it is perfectly possible to extend requirement groups without errors - as I did, and double tested to be sure

Describe alternatives you've considered

Testing

Additional context

No item migration because the item wasn't available outside debug anyway. If people more important than me wish for me to handle the migration regardless of this, I will.

This is going to require tileset files to be renamed after its merged.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Monsters Monsters both friendly and unfriendly. Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 31, 2024
@Maleclypse Maleclypse merged commit 0527e71 into CleverRaven:master Sep 1, 2024
23 of 28 checks passed
@Karol1223 Karol1223 deleted the destroy-generic-egg branch September 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Mind Over Matter Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants