Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chance for moose, coyotes, and rattlesnakes to birth mutant babies #76211

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Sep 5, 2024

Summary

None

Purpose of change

#75830 is closed. My prayers have been answered.

Describe the solution

  • Add a 5% chance for non-mutated coyotes, moose, or timber rattlesnakes to birth a mutant baby instead of a normal one
  • By extension I had to add mutant coyote pups, and made mutant coyotes reproduce as well
  • Delayed tusked moose spawns by how long it takes for a tusked moose calf to grow to adulthood post Moose audit #74554
  • Re-added mutant coyote spawns that got removed... at some point? I honestly don't know when. I just know they didn't spawn
  • Re-added mutant rattlesnake spawns because I accidentally removed them entirely in Some new reptiles #75829

Describe alternatives you've considered

  • Beavers - next in line, I'll get to them soon, they need it the most because similar to mutant coyotes, mutant beavers stopped spawning a while ago
  • Raccoons, bears, deer - I'll get to them while auditing their non-mutated counterparts
  • Crows, carp - need a more thorough audit in a separate PR
  • Dogs, frogs - I don't want to make a bazillion monstergroups for all types of them yet so I'm putting it off
  • Salmon - needs a couple new babies to get the same treatment rattlesnakes did here

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. labels Sep 5, 2024
@Karol1223 Karol1223 changed the title Chance for moose, coyotes, and rattlesnake to birth mutant babies Chance for moose, coyotes, and rattlesnakes to birth mutant babies Sep 5, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 5, 2024
@Karol1223 Karol1223 marked this pull request as draft September 5, 2024 11:30
@Karol1223
Copy link
Contributor Author

Drafting because apparently copy-from overwriting for reproduction fields doesn't work properly.

@Venera3
Copy link
Member

Venera3 commented Sep 6, 2024

For repro testing you can do a very short timer and a lot of mobs, then teleporting and back repeatedly while incrementing time via the debug menu (when they are unloaded).
You don't need to test "do they spawn mutants at exactly 5%", just some rough tests to ensure group repro and any timers on them work.

@Karol1223
Copy link
Contributor Author

For repro testing you can do a very short timer and a lot of mobs, then teleporting and back repeatedly while incrementing time via the debug menu (when they are unloaded). You don't need to test "do they spawn mutants at exactly 5%", just some rough tests to ensure group repro and any timers on them work.

Yeah so it turned out the reason I couldn't test it was because copy-from overwriting for the field is kinda broken. For some reason I didn't get an error on load when opening the game, but everyone else on the discord seems to get the error as well.

@Karol1223 Karol1223 marked this pull request as ready for review September 10, 2024 12:56
data/json/monsters/mutant_mammal.json Outdated Show resolved Hide resolved
data/json/monsters/mutant_mammal.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 10, 2024
@Karol1223 Karol1223 marked this pull request as draft September 10, 2024 17:34
@ADekema
Copy link

ADekema commented Sep 18, 2024

A fun idea: How about giving the mutants also a chance to give birth to normal babies as well?

@Karol1223
Copy link
Contributor Author

A fun idea: How about giving the mutants also a chance to give birth to normal babies as well?

No

@Karol1223
Copy link
Contributor Author

So this should actually be ready to go. In theory. The problem is I cannot, anything I do, get it to work ingame. This, famously, is bad and a reason against merging a PR.

So uh. Anyone wants to give testing this a shot and give me a hand? Because I've been abusing these damn coyotes for the last 5 days and I cannot get them to reproduce no matter what I do.

@GuardianDll
Copy link
Member

Wasn't able to call the reproduction also, but updating the branch to the recent master fixed it, somehow
image

@GuardianDll GuardianDll marked this pull request as ready for review September 24, 2024 21:03
@Karol1223 Karol1223 mentioned this pull request Sep 26, 2024
@Maleclypse Maleclypse merged commit 9791584 into CleverRaven:master Sep 29, 2024
40 checks passed
@Karol1223 Karol1223 deleted the vertebrate-mutants branch September 29, 2024 08:13
@Karol1223 Karol1223 mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants