Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plastic tub audit #76596

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

bloodbowel
Copy link
Contributor

Summary

Features "Plastic tub audit"

Purpose of change

I remember from a while ago the plastic tub has two major issues. It being an open container and it dropping too many plastic chunks when cut apart.

Describe the solution

  1. Although the plastic tub cover is flimsy, it shouldn't spill unless you carry it upside down in your pack and shake it. This is similar to the situation with a gallon jug. It does have a lid of some sort, so I removed the open container flag.
  2. The plastic tub drops a lot more plastic chunks than expected when cut apart. 25 chunks. A gallon jug drops 2 in comparison. I reduced its weight significantly to fix this. Now it drops 4 chunks, which seems about right because the plastic is thicker than a jug.

Describe alternatives you've considered

The weight might be tweaked some more, but this seems appropriate enough to me.

Testing

Tested in debug mode in the tutorial room on my computer.

Additional context

Reference:
reference

Testing:
test

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 21, 2024
@Maleclypse Maleclypse merged commit 4c45f3d into CleverRaven:master Sep 29, 2024
20 of 26 checks passed
@bloodbowel bloodbowel deleted the plastic-tub-audit branch October 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants