Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check if faction is lone wolf instead of "no_faction" ID #76614

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Actually check if faction is lone wolf instead of "no_faction" ID #76614

wants to merge 1 commit into from

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

It was brought to my attention that lone_wolf_faction is never actually used

Describe the solution

Properly check if the faction is tagged as lone_wolf_faction instead of just checking against the static no_faction ID

Describe alternatives you've considered

Testing

Needs testing, hasn't been tested. Hence draft

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RenechCDDA