Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Earthshapers cannot Stone Slumber unsafely #76615

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[Magiclysm] Earthshapers cannot Stone Slumber unsafely"

Purpose of change

Report on the Discord of someone using Stone Slumber and then falling into lava because they were near a balrog mine. On the one hand, sinking into a balrog mine seems like a reasonable way to have real problems, but on the other hand, we're trying to avoid gotcha instadeaths.

Describe the solution

Check that the terrain you sink into is actually solid rock before moving you there.

Describe alternatives you've considered

Testing

Cast the spell above a balrog mine. It did not work and the mana was refunded. Cast it elsewhere, it worked normally.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 22, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 22, 2024
@Maleclypse Maleclypse merged commit 7119fd8 into CleverRaven:master Sep 24, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the earthshaper-safe-earth-sink branch September 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants