Use typed tripoints in npcmove and adjacent code #76623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
mqrause
force-pushed
the
typed_npcmove
branch
from
2db1331
to
b822773
Compare
github-actions
bot
added
the
Code: Tests
github-actions
bot
added
the
BasicBuildPassed
PatrikLundell
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looked at all the changes without finding anything suspect, but rather the expected tedium. The automatic stuff complains about improvements to error messages and wants some other operation, something I have no opinion on, but guess those demands have to be met regardless.
mqrause
force-pushed
the
typed_npcmove
branch
2 times, most recently
from
80e8012
to
cee23e2
Compare
akrieger
reviewed
Sep 24, 2024
github-actions
bot
removed
the
BasicBuildPassed
mqrause
force-pushed
the
typed_npcmove
branch
2 times, most recently
from
67cb33a
to
c6a2802
Compare
mqrause
force-pushed
the
typed_npcmove
branch
from
c6a2802
to
378c24a
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Typed tripoints.
Describe the solution
Convert tripoints mostly to tripoint_bub_ms.
Added a method to get the midpoint between an arbitrary number of points.
Describe alternatives you've considered
Testing
Spawned an NPC, watched it seek out the nearest shelter, made it follow me around, fight some zombies, sort some loot. Everything seemed normal.
Additional context