Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit/NO_I18N for effects.json #76698

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "Audit/NO_I18N effects.json"

Purpose of change

Add NO_I18N flag to AI/monster effects.json

Describe the solution

  1. Add the NO_I18N flag itself.
  2. The file is supposed to be divided into two parts, first the effects for monsters, then for the player. Move some effects to the beginning of the file.
    "//": "ACTUAL PLAYER EFFECTS START HERE",
  3. Add a show_in_info field for a couple of effects. For example, effects of broken body parts, or spore coating. NPCs for some reason do not show some effects in the x-menu, probably because these effects do not work for them(?), so this list of effects is a little shorter than I intended. (general monsters get these effects correctly, or at least show them)

Describe alternatives you've considered

Split effects into different files?
Replace untranslatable descriptions with comments? Although they can still be seen in the debug menu.
Please let me know if I changed anything wrong, like, if the effect can be seen somewhere during normal play.

Testing

The marked strings are not extracted for translation as expected.
Снимок экрана_2024-09-26_11-01-05
Снимок экрана_2024-09-26_11-04-19
Снимок экрана_2024-09-26_11-05-03
Снимок экрана_2024-09-27_20-10-16
Снимок экрана_2024-09-27_20-27-47
Снимок экрана_2024-09-26_10-58-00

Additional context

Снимок экрана_2024-09-26_10-56-38
Cows and tying up are kind of bugged. Cows don't get the "Milked" effect (the effect was given manually), and effect "Tied Up" doesn't cancel "Being Led By Leash" effect. The action menu also has both of these actions: untie and stop leading.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Translation I18n astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 28, 2024
@Maleclypse Maleclypse merged commit 9188a89 into CleverRaven:master Sep 30, 2024
27 checks passed
@Uwuewsky Uwuewsky deleted the no-i18n-effect branch September 30, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants