-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #76534 Hair Growth After Haircutting is normal now. #76705
Closes #76534 Hair Growth After Haircutting is normal now. #76705
Conversation
I’ve addressed the issue related to hair growing instantly. Issue - CleverRaven#76534. The problem was indeed with the recurrence values in the appearance_eocs.json file. I’ve updated the recurrence math to use a fixed number, which should prevent hair growth from happening too quickly.
Co-authored-by: Anton Simakov <[email protected]>
Co-authored-by: Anton Simakov <[email protected]>
Co-authored-by: Anton Simakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good if the time function works properly then this feature should not work as it should. The recurrence I had set up worked because beard growth is most likely programmed somewhere else to grow faster than hair growth. Hair growth is programmed to be slower. Hence the numbers come out to different times but actually result inside the game at around the respective times I said.
I’ve addressed the issue related to hair growing instantly. Issue - #76534. The problem was indeed with the recurrence values in the appearance_eocs.json file. I’ve updated the recurrence math to use a fixed number, which should prevent hair growth from happening too quickly.
Summary
Bugfixes "Fixed hair growth and balding issue in appearance_eocs.json"
76534 Purpose of change
Describe the solution
The recurrence values were set to a fixed number instead of relying on faulty health-dependent calculations. This ensures that hair growth follows a more realistic timeline, fixing the rapid growth and inappropriate balding that was happening. I believe that there was no reason to use health within the calculations.
Describe alternatives you've considered
If using health dependent calculations is important to the developers then possibly lowering the number that multiplies the health significantly would be another approach to fixing the issue in a different way.
Testing
I tested the changes by creating a character with natural hair growth, cutting their hair, and using the debug menu to see how fast the hair and beard would grow. Along with this I also made sure to add my own logging which is not being committed. The logging would tell me which traits were being added and when.
Additional context