Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #76534 Hair Growth After Haircutting is normal now. #76705

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

Fabiang120
Copy link
Contributor

I’ve addressed the issue related to hair growing instantly. Issue - #76534. The problem was indeed with the recurrence values in the appearance_eocs.json file. I’ve updated the recurrence math to use a fixed number, which should prevent hair growth from happening too quickly.

Summary

Bugfixes "Fixed hair growth and balding issue in appearance_eocs.json"

76534 Purpose of change

Describe the solution

The recurrence values were set to a fixed number instead of relying on faulty health-dependent calculations. This ensures that hair growth follows a more realistic timeline, fixing the rapid growth and inappropriate balding that was happening. I believe that there was no reason to use health within the calculations.

Describe alternatives you've considered

If using health dependent calculations is important to the developers then possibly lowering the number that multiplies the health significantly would be another approach to fixing the issue in a different way.

Testing

I tested the changes by creating a character with natural hair growth, cutting their hair, and using the debug menu to see how fast the hair and beard would grow. Along with this I also made sure to add my own logging which is not being committed. The logging would tell me which traits were being added and when.

Additional context

I’ve addressed the issue related to hair growing instantly. Issue - CleverRaven#76534. The problem was indeed with the recurrence values in the appearance_eocs.json file. I’ve updated the recurrence math to use a fixed number, which should prevent hair growth from happening too quickly.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition new contributor <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 28, 2024
@Fabiang120 Fabiang120 changed the title Fixes #76534 Hair Growth After Haircutting is normal now. Closes #76534 Hair Growth After Haircutting is normal now. Sep 28, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 28, 2024
Copy link
Contributor Author

@Fabiang120 Fabiang120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good if the time function works properly then this feature should not work as it should. The recurrence I had set up worked because beard growth is most likely programmed somewhere else to grow faster than hair growth. Hair growth is programmed to be slower. Hence the numbers come out to different times but actually result inside the game at around the respective times I said.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 28, 2024
@Maleclypse Maleclypse merged commit 3d5fa41 into CleverRaven:master Sep 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants