-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Fix Missing mind shield (0.H Backport) #76731
Merged
Maleclypse
merged 11 commits into
CleverRaven:0.H-branch
from
Standing-Storm:missing-mind-shield
Oct 2, 2024
Merged
[MoM] Fix Missing mind shield (0.H Backport) #76731
Maleclypse
merged 11 commits into
CleverRaven:0.H-branch
from
Standing-Storm:missing-mind-shield
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standing-Storm
changed the title
[MoM] Fix Missing mind shield
[MoM] Fix Missing mind shield (0.H Backport)
Sep 30, 2024
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mods: Mind Over Matter
<Bugfix>
This is a fix for a bug (or closes open issue)
<Enhancement / Feature>
New features, or enhancements on existing
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Info / User Interface
Game - player communication, menus, etc.
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Sep 30, 2024
So it's expected for 0.H but already obsolete in experimental? That explains it. |
Experimental I reworked how the portal storm EoCs work to account for Telepathic Shield (if you have MoM running), but that's not in 0.H, hence the item. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
<Enhancement / Feature>
New features, or enhancements on existing
Info / User Interface
Game - player communication, menus, etc.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "[MoM] Fix Missing mind shield (0.H Backport)"
Purpose of change
Reported on Discord--the mindshield item (necessary for 0.H's version of protection from portal storms when using Telepathic Shield) did not get backported.
Describe the solution
Backport the item. All the infrastructure to handle it is already in place.
Describe alternatives you've considered
Testing
Additional context