Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Fix Missing mind shield (0.H Backport) #76731

Merged
merged 11 commits into from
Oct 2, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Sep 30, 2024

Summary

Bugfixes "[MoM] Fix Missing mind shield (0.H Backport)"

Purpose of change

Reported on Discord--the mindshield item (necessary for 0.H's version of protection from portal storms when using Telepathic Shield) did not get backported.

Describe the solution

Backport the item. All the infrastructure to handle it is already in place.

Describe alternatives you've considered

Testing

Additional context

@Standing-Storm Standing-Storm changed the title [MoM] Fix Missing mind shield [MoM] Fix Missing mind shield (0.H Backport) Sep 30, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 30, 2024
@Psithief
Copy link
Contributor

So it's expected for 0.H but already obsolete in experimental? That explains it.

@Standing-Storm
Copy link
Contributor Author

So it's expected for 0.H but already obsolete in experimental? That explains it.

Experimental I reworked how the portal storm EoCs work to account for Telepathic Shield (if you have MoM running), but that's not in 0.H, hence the item.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 1, 2024
@Maleclypse Maleclypse merged commit 1240ace into CleverRaven:0.H-branch Oct 2, 2024
20 of 22 checks passed
@Standing-Storm Standing-Storm deleted the missing-mind-shield branch October 2, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants