New end screens ! #76732
Merged
New end screens ! #76732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdlpoppa
changed the title
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
github-actions
bot
added
the
json-styled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds new end screen for thresh types, and a unique one."
Purpose of change
End screens are incredibly neat, however extremely lacking. While a pretty plain reason, I believe this would spice up character deaths, giving a special (to cope with the fact that you're character is dead) screen. Right now, these are pretty simplistic, and probably not well made considering my amateur ability at ascii art, but I hope to make more in future PR's.
Describe the solution
Using the semi-recently JSON-ized end screens (which really are impressive, see #74844 ) I typed up some end screens, generally based on aspects of said mutation, like a mushroom for marloss, bird skull for bird, cut off lizard tail for lizard, ect. and attempted to display these as best I could in the relatively small area given.
Describe alternatives you've considered
N/A
Testing
Quite alot of testing, as you can't view the end screens without your character...being dead. ALOT of dead characters. Hopefully all the end screens should look relatively nice, and nothing extremely misplaced.
Additional context
Pictures of end screens:
