Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Dont extract monster/fake spells/effects for translation #76736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "[MoM] Dont extract monster/fake spells/effects for translation"

Purpose of change

The names and descriptions of NPC/monster/trap spells/effects etc. were available for translation.

Describe the solution

Mark such names with a flag to skip extraction into translation files.
And replace the message in the remaining practice recipe.

Please let me know if I changed anything wrong, like, if the effect can be seen somewhere during normal play.

Describe alternatives you've considered

Testing

The game loads correctly. Marked names are now missing from .pot file.

Additional context

"name": "telekinetic powers",
"//": "Name is so it displays properly in the message log.",

I skipped that just in case, but I wonder if it actually shows up in the message log? The message for this spell looks like this:
"monster_message": "%1$s stares at %3$s and %3$s is lifted up and pulled towards them!"

Снимок экрана_2024-09-26_12-50-35

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter Translation I18n json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Mind Over Matter Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant