Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PULL_WEAPON monattack and use in relevant areas #76747

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b3brodie
Copy link
Contributor

Summary

Infrastructure "Add PULL_WEAPON monattack and use in relevant mods"

Purpose of change

Most cases of PULL_METAL_WEAPON are currently used in situations where they shouldn't actually care if the weapon is metal or not. Add new monster attack that doesn't care about the item material and switch these cases over.

Describe the solution

Basically reuse the pull_metal_weapon code but cut out all the segments related to material checking.
Switch old monattacks over if they shouldn't care about material.

Describe alternatives you've considered

N/A

Testing

weapon pulling

Additional context

N/A

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 30, 2024
@Venera3
Copy link
Member

Venera3 commented Oct 1, 2024

Instead of expanding hardcoded monattacks I'd suggest moving it/both over to the JSON mattack infra - that lets you modify the attack on a per-monster basis and makes deprecating monattacks easier down the line.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 1, 2024
@b3brodie b3brodie marked this pull request as draft October 5, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants