Fix: Allow tools with charged batteries to be modded

[Pabblusansky]

Summary

None

Purpose of change

Simply makes it possible to attach mods to tools. fixes #76717

Testing

Compiled the game and tested - attaching the mod to a tool works perfectly.

[Maleclypse]

Hey so I'm trying to understand why someone would do this when the e-ink has { "type": "link_up", "cable_length": 4, "charge_rate": "10 W" }

[Maleclypse]

Hey so I'm trying to understand why someone would do this when the e-ink has { "type": "link_up", "cable_length": 4, "charge_rate": "10 W" }

There may be a good reason. And if so I’m open to it.

[Pabblusansky]

Hey so I'm trying to understand why someone would do this when the e-ink has { "type": "link_up", "cable_length": 4, "charge_rate": "10 W" }

Hi. So the PR is not about the charge_rate of the e-ink PC, it's about the impossibility of attaching a tool (power conversion, battery, etc) to a charged device. Please see the original issue: #76717 for more context.

[GuardianDll]

Do you happen to know how easy it would be to disable link_up use action if toolmod is attached? bugfix is desired, but i am afraid it would allow to use both batteries and link_up action, which is busted and probably not very desired

[Maleclypse]

Please review the name change above. I renamed this PR to make it more accurate since it's scope is larger than e-ink items. This seems like a change that's going to cause other downstream bugs potentially so I'll have to leave this decision to other mergers with stronger code backgrounds.

[Pabblusansky]

Do you happen to know how easy it would be to disable link_up use action if toolmod is attached? bugfix is desired, but i am afraid it would allow to use both batteries and link_up action, which is busted and probably not very desired

Oh, I'm sorry. A bit confused, now I understand the point of the question. I'll try to see if I can do something about this potential “exploit”, but if it doesn't work, I think I'd listen to the opinions of other contributors.

[kevingranade]

It's not so much an exploit as it is "a very high risk of introducing new bugs".
The exemplar of the e-ink tablet in particular is pretty much invalid anyway, it already has a battery and a charger, that's all it's supposed to have and adding a battery pack isn't really a sensical thing to do.

[Pabblusansky]

Okay, closing the PR.