Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure crushed characters are fetched from the correct location #77805

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #77786, i.e. crushing due to explosions using the reality bubble coordinates rather than the coordinates of the explosion map.

Describe the solution

Fetch the character from the correct global coordinates rather than feeding the explosion bubble coordinates into a fetch operation that does the same conversion but using the official reality bubble as the coordinate reference.

Describe alternatives you've considered

Testing

Followed the instructions in the bug report save, verifying the issue (and locating the location where it goes wrong through the debugger).
Modified the code.
Repeated the bug report replication, seeing no reports about the PC being affected by anything.

Additional context

This is a side effect of the change to make explosions with effects at least partially outside of the reality bubble being performed in their own map. The creature tracker, however, is always assuming bubble coordinates refer to the official reality bubble, so you have to make use of the corresponding operation using absolute coordinates to get the correct result.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 13, 2024
@Night-Pryanik Night-Pryanik merged commit d4abac3 into CleverRaven:master Nov 13, 2024
22 of 28 checks passed
@PatrikLundell PatrikLundell deleted the explosion branch November 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crushed by debris from bomb 60 tiles away
2 participants