Mycus innate dimensional stability

[Kamejeir]

Summary

Features "Mycus are now dimensionally stabilized"

Purpose of change

It strikes me that Mycus, as much as they want to employ humans, don't account for the world falling apart potentially being very lethal for all their natives turned superspreaders.

The Mycus is, if not close to being, a dimensionally transcendent species (on the Basically Magic end of "technology tree/power level" scale) and would believably have this ability.

Describe the solution

New mutation for the Mycus with the innate effects of a 5-point anchor.

Add conditions to all (tell me if I missed any) checks of DIMENSIONAL_ANCHOR to account for character flags.

(from seeing how this block of code does it, I believe that there isn't really a cleaner solution to be worried about)

Cataclysm-DDA/data/mods/Magiclysm/Spells/monsterspells.json

Lines 386 to 388 in daebd7d

	{ "not": { "u_has_flag": "BLIND" } },
	{ "not": { "u_has_effect": "BLIND" } },
	{ "not": { "u_has_worn_with_flag": "BLIND" } }

Describe alternatives you've considered

Testing

I've tested different cases of having a 5-point anchor and Mycus Stability versus a Flaming Eye, then from that working, assume that it will work for all modded interactions of a similar structure.

The same kind of tests have been performed for the C++ based checks, except that I couldn't come up with a way to reliably make something telefrag me.

This being in draft: I think I should try to mutate it naturally first. Also I want to see if there's any way to make the description better.

I got nothing of note to say other than having tested getting the mutation.

Additional context

Yes, this does prevent Mycus people from using the Probability Travel CBM.

It's odd that you get extra non-marloss/mycus mutations, but ok.

[SariusSkelrets]

Would making the mutation grant an integrated armor with the flags be less intrusive code-wise?

It have the benefit of not needing to change every single Json line in which DIMENSIONAL_ANCHOR is used and not having to do a "or" check every time something checking DIMENSIONAL_ANCHOR is called.

Allowing to directly apply the effect without needing gear does have its benefits even if making that the character and item flags for it are one and the same, both preventing duplication and not needing integrated armor, would be the best choice of the three.

[kevingranade]

The rationale for this makes no sense. It just makes wild assertions about mycus being dimensionally transcendent (it's not, at all) and that it would "believably have" this ability.