Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
This makes it possible to reason about a generic point object that may be a raw point / tripoint or a typed coordinate. This came up in #75961.
In particular, the change would allow expressing the following line:
for which there is currently no way to express. This would also allow getting rid of some overloads in favour of generic implementations (e.g. the
closest_point_first
overloads in coordinates.h)Describe the solution
Add
raw()
methods to point and tripoint that create a new object with the same details.Describe alternatives you've considered
Adding
raw
at callsites. This means that points have to be converted to the correct type system at the callsite, which is less than ideal.Using
template<typename Point, coords::origin Origin, coords::scale Scale>
. However, I don't think this works with raw points, so they would have to be converted.Testing
Additional context