-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item: let translators reorder tname segments #77885
Conversation
This is for |
That's really cool. Thank you for doing this! |
Yep, thank you, that would be really helpful.
You can add a comment to |
c0f5ad9
to
382a5fe
Compare
There's a translation comment here and I've verified that it gets exported to the .pot file |
Thanks for merging |
Summary
None
Purpose of change
Item name segments are printed in a hardcoded order that makes sense in English but maybe not so much in other languages.
Describe the solution
Read the segment order from a translatable string
This string is fixed in English (
tname_segments_order
) so that translator-specified order still works when translations are out of sync with new segments.New segments that aren't specified in
tname_segments_order
are printed at the end of the name in hardcoded orderThe
CONTENTS
segment (and any after it) has a fixed place and can't be changedDescribe alternatives you've considered
N/A
Testing
New test unit
Manual testing:
I changed the order for es_ES to place `BURN` after `TYPE`
Additional context
I'm concerned that this is too convoluted and has low visibility. It seems pretty fragile too.Uwuewsky can you take a look? You asked about this on discord a few months ago.