Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sees_player_hitbutton mod #77974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

We don't ship with HitButton iso, it got remade into SmashButton iso but that includes see_player icons (here)

Describe the solution

Removes the mod and adds it to the removed mods list

Describe alternatives you've considered

I'm trying to find out if the retrodays equivalent is just a relic that wants removing in favour of base tileset sprites or whether it should be changed to an in game option to toggle their extra icons off that has an auto option that uses tileset defined setting for intentional stylistic choices if that is the case

Testing

Additional context

The mod as is should still work fine for anyone that is still using HitButton iso for any reason if you want to just dl it from any previous master (eg https://github.com/CleverRaven/Cataclysm-DDA/tree/197090e35560d270f5a756da4b88ea9488480f04/data/mods/sees_player_hitbutton)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 18, 2024
@GuardianDll
Copy link
Member

don't we need to obsolete it first before removing?

@Procyonae
Copy link
Contributor Author

Why?

@GuardianDll
Copy link
Member

players who still has it would get an error about mod missing otherwise, no?

@Procyonae
Copy link
Contributor Author

That's what the bit just below the addition in game.cpp is for (also what would obsoleting it for a while achieve in the regard)

When I added that I'd forgotten that replacements.json is a thing but I don't like that that does it silently rather than a one time prompt that allows peeps to go readd mods or just find out something borked if using a launcher or whatever so I'm going to unhardcode this into proper json object removals and migration in /data/core and merge the two I just haven't gotten to it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants