Remove sees_player_hitbutton mod #77974
Open
+5
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
We don't ship with HitButton iso, it got remade into SmashButton iso but that includes see_player icons (here)
Describe the solution
Removes the mod and adds it to the removed mods list
Describe alternatives you've considered
I'm trying to find out if the retrodays equivalent is just a relic that wants removing in favour of base tileset sprites or whether it should be changed to an in game option to toggle their extra icons off that has an auto option that uses tileset defined setting for intentional stylistic choices if that is the case
Testing
Additional context
The mod as is should still work fine for anyone that is still using HitButton iso for any reason if you want to just dl it from any previous master (eg https://github.com/CleverRaven/Cataclysm-DDA/tree/197090e35560d270f5a756da4b88ea9488480f04/data/mods/sees_player_hitbutton)