Feat/handshake config #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds manifest tag as placeholder - parses the manifest label and saves in string - adds constants and fluff
- base url impl was hidden - readable code to see url building and passing
- adds custom domain through instance to api class - modifies tests to handle new change - will think of better design to hold account vars together
- proper request handling - naming for viewed event endpoint check
- needs handshake is changed as per new data in manifest - adds test case for above to return handshake url - separates handshake and other api call url builder - verbose url building - adds cached handshake filed in ct api
- corrects set handshake domain method - names to call args in CtApi.kt - rename cached fields to make tests readable - idiomatic kotlin way in UrlConnectionHttpClient.kt
- adds custom handshake header as needed by feature - headers gets added only in handshake request and if mentioned in manifest - adds tests to confirm the headers and url
CTLalit
requested review from
Anush-Shand,
vasct,
darshanclevertap and
piyush-kukadiya
Anush-Shand
reviewed
Sep 16, 2024
clevertap-core/src/main/java/com/clevertap/android/sdk/ManifestInfo.java
Show resolved
Hide resolved
Anush-Shand
reviewed
Sep 16, 2024
Anush-Shand
reviewed
Sep 16, 2024
Anush-Shand
reviewed
Sep 16, 2024
clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/images/Extensions.kt
Outdated
Show resolved
Hide resolved
Anush-Shand
reviewed
Sep 16, 2024
clevertap-core/src/main/java/com/clevertap/android/sdk/network/NetworkManager.java
Outdated
Show resolved
Hide resolved
Anush-Shand
requested changes
Sep 16, 2024
- sets data from manifest to default instance - moves method to ct extensions - fixes logging
- test creds removal
- clears cached handshake value correctly - tests manifest swap bw custom handshake, region back and forth
- needsHandshake() method test cases for various configs
- they are not needed, it was making code navigation complex, also they were not needed.
clevertap-core/src/main/java/com/clevertap/android/sdk/network/api/CtApi.kt
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/network/api/CtApi.kt
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/network/api/CtApi.kt
Show resolved
Hide resolved
- needs no handshake when mentioned first time, migration to be done via redirection headers in /a1 api call - changes methods in ctapi, also need to clear any previously cached handshake performance info (did/did not do)
- removes cached handshake info as its not needed - there were checks based on cached info so we can identify config added first time
Network layer changes for handshake support.
- changes are made to logic so tests are changed acc
- ignores flaky test cases - compliances around image urls we need to use need to be considered
feat(SDK-4076): Changes need handshake logic
- cleaned up the class and added easier access to create instance with config
- adds method for change creds for custom handshaking.
Anush-Shand
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in this ticket :
https://wizrocket.atlassian.net/browse/SDK-4042