Point and Click feature #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkyusuftk
requested changes
May 14, 2024
| @@ -0,0 +1,146 @@ | |||
| export const initialiseCTBuilder = (url, variant, details) => { | |||
There was a problem hiding this comment.
general review, lets add jsdoc comments to all functions
https://jsdoc.app/
| container.style.position = 'relative' // Ensure relative positioning for absolute positioning of form | ||
| container.style.display = 'flex' | ||
| document.body.appendChild(container) | ||
| const overlayPath = 'https://d2r1yp2w7bby2u.cloudfront.net/js/lib-overlay/overlay.js' |
There was a problem hiding this comment.
lets remove this hard coded string here. Add a new constants file inside visualBuilder and add this string
| var link = document.createElement('link') | ||
| link.rel = 'stylesheet' | ||
| link.type = 'text/css' | ||
| link.href = 'https://d2r1yp2w7bby2u.cloudfront.net/js/lib-overlay/style.css' |
Comment on lines
61
to
70
| var d = document | ||
| var h = d.documentElement | ||
| var t = setTimeout(function () { | ||
| h.className = h.className.replace(/\bwf-loading\b/g, '') + ' wf-inactive' | ||
| // $(document).trigger("TypeKitReady"); | ||
| }, config.scriptTimeout) | ||
| var tk = d.createElement('script') | ||
| var f = false | ||
| var s = d.getElementsByTagName('script')[0] | ||
| var a |
There was a problem hiding this comment.
meaningful name of the variables.
Also define them as const
src/util/tr.js
Outdated
Comment on lines
51
to
53
| // msg = { | ||
| // arp: { | ||
| // j_n: 'Zw==', |
There was a problem hiding this comment.
no commented code please
kkyusuftk
reviewed
May 17, 2024
src/clevertap.js
Outdated
|
|
||
| if (search === '?ctBuilder') { | ||
| // open in visual builder mode | ||
| console.log('open in visual builder mode') |
There was a problem hiding this comment.
can we use our logger class here
kkyusuftk
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue: WEB-2848
Implementation