Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web 2896 #221

Merged
merged 3 commits into from
May 28, 2024
Merged

Web 2896 #221

merged 3 commits into from
May 28, 2024

Conversation

ajtret
Copy link
Contributor

@ajtret ajtret commented May 27, 2024

A grey line below the carousel banner image is seen while preview and rendering web native campaigns..

Screenshot 2024-05-24 at 17 47 53

@ajtret ajtret changed the base branch from master to develop May 27, 2024 12:09
@ajtret ajtret requested a review from KambleSonam May 27, 2024 12:09
Copy link
Collaborator

@KambleSonam KambleSonam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Build files as well

@KambleSonam KambleSonam self-requested a review May 28, 2024 09:05
@kkyusuftk kkyusuftk changed the base branch from develop to master May 28, 2024 10:30
@kkyusuftk kkyusuftk changed the base branch from master to develop May 28, 2024 10:31
@ajtret ajtret merged commit 33942c1 into develop May 28, 2024
2 checks passed
ajtret added a commit that referenced this pull request May 28, 2024
* Event,profile,OUL handling

* Added condition for old and new campaigns

* Optimised code, removed duplicate code

* Removed hard-coded flag and using proper sandbox flag sent from dashboard

* added support for close popup

* added allow-forms for form submissions

* new file for ctHandler script, optimised code

* added constants in constants.js

* missed custom flag in last commit

* Node version fix in github workflows

* restrict the mac os version

* restrict the mac os version

* restrict the mac os version

* restrict the mac os version

* Changelog and version update

* revert Xss changes!

* remove cthandler and constants

* Web 2896 (#221)

* [WEB-2896]: Removing backgound color from carousel / banner campaigns

* [WEB-2896]: Removing backgound color from carousel / banner campaigns

---------

Co-authored-by: Shubham Jadhavar <[email protected]>
Co-authored-by: Akshat Jhalani <[email protected]>
@kkyusuftk kkyusuftk mentioned this pull request Jun 11, 2024
@kkyusuftk kkyusuftk deleted the WEB-2896 branch June 11, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants