Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3310] Fixed Inbox Open Not Working for SPA App #296

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

singhkunal2050
Copy link
Contributor

Changes

WEB-3310 The DOM Node that we are storing duing clevertap Initialization becomes stale due to the framework re-rendering the node(ideally SPAs do not rerender the nodes that are not changed)
Hence the condition this.inboxSelector.contains(e.target) is failing, where this.inboxSelector becomes stale after route change. Refer here

To solve this

Changes to Public Facing API if any

No Changes

How Has This Been Tested?

Tested the WebInbox on home page and changed route and checked again on different routes

Checklist

  • Code compiles without errors
  • Version Bump added to package.json & CHANGELOG.md
  • All tests pass
  • Build process is successful
  • Documentation has been updated (if needed)

@singhkunal2050 singhkunal2050 merged commit 3354760 into master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants