Add topography option to support Hughes2023 double-mountain config #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
akshaysridhar
force-pushed
the
as/hughes23-test
branch
from
eddced1
to
69d95de
Compare
akshaysridhar
force-pushed
the
as/hughes23-test
branch
2 times, most recently
from
180b5ed
to
9cda4f1
Compare
|
What's the status of this PR? |
akshaysridhar
force-pushed
the
as/hughes23-test
branch
5 times, most recently
from
0a3e176
to
f3fbea7
Compare
akshaysridhar
force-pushed
the
as/hughes23-test
branch
7 times, most recently
from
c37a34d
to
6e0d534
Compare
szy21
reviewed
Aug 30, 2024
config/model_configs/sphere_baroclinic_wave_rhoe_hughes2023.yml
Outdated
Show resolved
Hide resolved
config/model_configs/sphere_baroclinic_wave_rhoe_hughes2023.yml
Outdated
Show resolved
Hide resolved
.buildkite/pipeline.yml
Outdated
| @@ -380,6 +380,13 @@ steps: | |||
| --config_file $CONFIG_PATH/sphere_baroclinic_wave_rhoe_topography_dcmip_rs.yml | |||
| --job_id sphere_baroclinic_wave_rhoe_topography_dcmip_rs | |||
| artifact_paths: "sphere_baroclinic_wave_rhoe_topography_dcmip_rs/output_active/*" | |||
|
|
|||
| - label: ":computer: baroclinic wave (ρe) topography (hughes2023)" | |||
akshaysridhar
force-pushed
the
as/hughes23-test
branch
2 times, most recently
from
ccadaef
to
b985e96
Compare
szy21
reviewed
Aug 30, 2024
| @@ -0,0 +1,16 @@ | |||
| dt_save_state_to_disk: "2days" | |||
| initial_condition: "DryBaroclinicWave" | |||
There was a problem hiding this comment.
Should this be MoistBaroclinicWave? Also are the initial condition exactly the same, or is there any perturbation related to topography?
akshaysridhar
force-pushed
the
as/hughes23-test
branch
from
b985e96
to
8e5886c
Compare
modified: src/initial_conditions/initial_conditions.jl modified: src/solver/type_getters.jl modified: src/topography/topography.jl + Hughes2023 testcase
akshaysridhar
force-pushed
the
as/hughes23-test
branch
from
ca50bf4
to
d6261b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.