Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integrator interface, add flame script #482

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Use integrator interface, add flame script #482

merged 1 commit into from
Jan 27, 2022

Conversation

charleskawczynski
Copy link
Member

This PR adds a flame script to the repo, and changes the monitored drivers to use OrdinaryDiffEq.jl's integrator interface. This should help make the analysis a bit more streamlined.

@simonbyrne
Copy link
Member

Is the pprof-generated site static? Could we generate it on buildkite, and post it to a webserver?

@charleskawczynski
Copy link
Member Author

Is the pprof-generated site static? Could we generate it on buildkite, and post it to a webserver?

I suspect it is, and that sounds great, but I'm not sure how to do that. Could we try to add that later?

@simonbyrne
Copy link
Member

Hmm, doesn't look like it is officially supported: google/pprof#670

Though apparently just saving the html mostly works: google/pprof#401 (comment)

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 27, 2022
@bors @charleskawczynski
Merge #482
63bc869 
482: Use integrator interface, add flame script r=charleskawczynski a=charleskawczynski

This PR adds a flame script to the repo, and changes the monitored drivers to use OrdinaryDiffEq.jl's integrator interface. This should help make the analysis a bit more streamlined.

Co-authored-by: Charles Kawczynski <[email protected]>
@jakebolewski
Copy link
Contributor

In addition to or instead of PProf could we generate a cpuprofile file assest?

https://github.com/julia-vscode/ChromeProfileFormat.jl

You can view these directly in vscode after downloading the file.

@charleskawczynski charleskawczynski mentioned this pull request Jan 27, 2022
Closed
@charleskawczynski
Copy link
Member Author

In addition to or instead of PProf could we generate a cpuprofile file assest?

Opened #483.

@bors
Copy link
Contributor

bors bot commented Jan 27, 2022

Canceled.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2022

Build succeeded:

@bors bors bot merged commit 4a69113 into main Jan 27, 2022
@bors bors bot deleted the ck/perf_monitoring branch January 27, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne approved these changes

@jakebolewski jakebolewski jakebolewski approved these changes

Assignees
No one assigned
Labels
Performance monitoring 🔍🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleskawczynski @simonbyrne @jakebolewski