Get rid of method redefinition warnings during precompile stage #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally gets rid of all the Casette warnings and a few other similar warnings due to method redefinitions.
Had to refactor the
FPlane
constructor to avoid a method redefinition. I chose to infer the float typeFT
from the inputs and remove the option to explicitly pass in anFT
. This is a breaking change (hopefully a minor one) but I couldn't think of another approach that would less intrusive.Suggestions welcome for other ways to resolve the ambiguity between
FPlane
constructors.Resolves #537
Resolves #366