Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datafusion v28 #127

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Datafusion v28 #127

merged 4 commits into from
Jul 31, 2023

Conversation

jychen7
Copy link
Contributor

@jychen7 jychen7 commented Jul 29, 2023

jychen7
jychen7 commented Jul 29, 2023
View reviewed changes
datafusion/results/single.json
[0.638, 0.563, 0.585],
[3.278, 3.119, 2.940],
[7.710, 4.401, 4.398],
[null, null, null],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Notably, apache/datafusion#6904 and related PRs for faster grouping performance show 2-3x performance improvements

@nickitat nickitat self-assigned this Jul 30, 2023
@nickitat
Copy link
Member

hi @jychen7
thanks for the contribution
could you pls update index.html - to do this you need to run generate-results.sh in the root ClickBench dir

jychen7
jychen7 commented Jul 31, 2023
View reviewed changes
index.html Show resolved Hide resolved
@jychen7
Copy link
Contributor Author

jychen7 commented Jul 31, 2023

@nickitat sure, done

@nickitat nickitat merged commit 643abc3 into ClickHouse:main Jul 31, 2023
@Dandandan Dandandan mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickitat nickitat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jychen7 @nickitat