Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #17294: Distinct on subquery with group by may return duplicates #17296

Closed

Conversation

chengxianglibra
Copy link

@chengxianglibra chengxianglibra commented Nov 23, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
fixes #17294 distinct on subquery with group by may return duplicates

@chengxianglibra chengxianglibra marked this pull request as draft November 23, 2020 09:22
@chengxianglibra chengxianglibra marked this pull request as ready for review November 23, 2020 09:24
@KochetovNicolai KochetovNicolai self-assigned this Nov 26, 2020
@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 26, 2020
@KochetovNicolai
Copy link
Member

Nice fix!
I have added some more tests in #17439

@chengxianglibra
Copy link
Author

distinct_names only need to be a subset of columns, i missed that, nice work.

@KochetovNicolai
Copy link
Member

Closing in favour of #17439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinct on subquery with group by may return duplicate result
4 participants