Add metrics for MergeTree parts (Wide/Compact/InMemory) types #19381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PartsWide - PartsCompact - PartsInMemory
…01600_parts_states_metrics Without this setting the test will pass only when the table will be actually removed by the background worker of the Atomic engine. In CI this is not required since database_atomic_wait_for_drop_and_detach_synchronously is set explicitly in via tests/users.d.
robot-clickhouse
added
the
pr-improvement
alexey-milovidov
approved these changes
Jan 21, 2021
Yes this is an option, and it will look simpler, but will require additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add metrics for MergeTree parts (Wide/Compact/InMemory) types
Follow up for #19122